Block Lords - Seascape

The EVM stack is a maximum of 16 deep. Every variable that is created will get pushed onto the stack. This includes function parameters and local variables. The Lord constructor uses too many parameters and local variables, which causes the following error to be displayed at compile time.

StackLimit

CompilerError: Stack too deep when compiling inline assembly: Variable headStart is 1 slot(s) too deep inside the stack.

Code Location

Lord.sol

constructor(
        address _seedSale,
        address _strategicSale,
        address _privateSale,
        address _launchpads,
        address _ieo,
        address _lordsBounty,
        address _kingsBounty,
        address _dynastyIncentives,
        address _liquidity,
        address _foundationReserve,
        address _advisor,
        bool _bridgeAllowed) ERC20("BLOCKLORDS", "LORD") {
        bridgeAllowed = _bridgeAllowed;
        uint256 _million = 1000 * 1000 * 10 ** 18;
        uint256 thousand = 1000 * 10 ** 18;

        if (!_bridgeAllowed) {
            _mint(_seedSale, 8 * _million + (750 * thousand));  // 8.75% of 100 million
            _mint(_seedSale, 6 * _million + (250 * thousand));  // 8.75% of 100 million
            _mint(_privateSale, 7 * _million);  // 8.75% of 100 million
            _mint(_launchpads, 2 * _million);  // 8.75% of 100 million
            _mint(_ieo, 1 * _million);  // 8.75% of 100 million
            _mint(_lordsBounty, 25 * _million);  // 8.75% of 100 million
            _mint(_kingsBounty, 10 * _million);  // 8.75% of 100 million
            _mint(_dynastyIncentives, 15 * _million);  // 8.75% of 100 million
            _mint(_liquidity, 10 * _million);  // 8.75% of 100 million
            _mint(_foundationReserve, 10 * _million);  // 8.75% of 100 million
            _mint(_advisor, 5 * _million);  // 8.75% of 100 million

            require(totalSupply() == 100 * _million, "not a 100 million tokens");
        }
    }

SOLVED: The minting process is now done address by address in several new functions.

The Lord.sol and Mead.sol smart contracts use .add() and .sub() functions located in the OpenZeppelin SafeMath library. This library is neither imported nor associated to a variable type (in this case uint256), so the mentioned functions cannot be used.

Code Location

Lord.sol

function mint(address to, uint256 amount) external onlyBridge {
        require(totalSupply.add(amount) <= limitSupply, "exceeded mint limit");
        _mint(to, amount);
    }

Lord.sol

function burnFrom(address account, uint256 amount) public onlyBridge {
        uint256 currentAllowance = allowance(account, _msgSender());
        require(currentAllowance >= amount, "burn amount exceeds allowance");

        _approve(account, _msgSender(), currentAllowance
            .sub(amount, "transfer amount exceeds allowance"));
        _burn(account, amount);
    }

Mead.sol

    function mint(uint256 _amount, uint8 _v, bytes32 _r, bytes32 _s) external {
        // investor, project verification
        bytes memory prefix     = "\x19Ethereum Signed Message:\n32";
        bytes32 message         = keccak256(abi.encodePacked(msg.sender, address(this), chainid, _amount, mintId, mintNonceOf[msg.sender]));
        bytes32 hash           = keccak256(abi.encodePacked(prefix, message));
        address recover         = ecrecover(hash, _v, _r, _s);

        require(bridges[recover], "sig");

        require(_totalSupply.add(amount) <= limitSupply, "exceeded mint limit");

        mintNonceOf[msg.sender]++;

        _mint(msg.sender, _amount);
    }

SOLVED: The SeaScape Team now implements correctly the SafeMath library.

The Lord.sol and Mead.sol smart contracts use _totalSupply variable to obtain the tokens total supply. This value is defined as a private variable in the OpenZeppelin ERC20 implementation; therefore, it should be obtained by using the get method totalSupply().

Code Location

Lord.sol

require(totalSupply == 100 * _million, "not a 100 million tokens");

Lord.sol

require(totalSupply.add(amount) <= limitSupply, "exceeded mint limit");

Mead.sol

require(_totalSupply.add(amount) <= limitSupply, "exceeded mint limit");

SOLVED: The SeaScape team now uses the totalSupply() method to retrieve the total token supply.

The Lord.sol, Mead.sol and ImportExportElasticNft.sol smart contracts use undefined variables, resulting in contracts which do not compile.

Code Location

• limitSupply (Lord.sol#93)
• bridgeAllowed (Mead.sol#36,46)
• amount (Mead.sol#73)
• memory_amount (Mead.sol#98)
• chainid (Mead.sol#67,90)

SOLVED: The SeaScape Team now implements the mentioned variables.

The onlyBridge modifier is never used in the code.

Code Location

Mead.sol

    modifier onlyBridge {
            require(bridges[msg.sender]);
        _;
    }

SOLVED: The SeaScape Team now uses the onlyBridge modifier on the mint and burn functions.

Several amounts are minted to the accounts, added as arguments in the constructor. Different amounts are minted twice in the _seedsale account, making this account 15 million instead of 8.75 million.

Code Location

Lord.sol

constructor(
        address _seedSale,
        address _strategicSale,
        address _privateSale,
        address _launchpads,
        address _ieo,
        address _lordsBounty,
        address _kingsBounty,
        address _dynastyIncentives,
        address _liquidity,
        address _foundationReserve,
        address _advisor,
        bool _bridgeAllowed) ERC20("BLOCKLORDS", "LORD") {
        bridgeAllowed = _bridgeAllowed;
        uint256 _million = 1000 * 1000 * 10 ** 18;
        uint256 thousand = 1000 * 10 ** 18;

        if (!_bridgeAllowed) {
            _mint(_seedSale, 8 * _million + (750 * thousand));  // 8.75% of 100 million
            _mint(_seedSale, 6 * _million + (250 * thousand));  // 8.75% of 100 million
            _mint(_privateSale, 7 * _million);  // 8.75% of 100 million
            _mint(_launchpads, 2 * _million);  // 8.75% of 100 million
            _mint(_ieo, 1 * _million);  // 8.75% of 100 million
            _mint(_lordsBounty, 25 * _million);  // 8.75% of 100 million
            _mint(_kingsBounty, 10 * _million);  // 8.75% of 100 million
            _mint(_dynastyIncentives, 15 * _million);  // 8.75% of 100 million
            _mint(_liquidity, 10 * _million);  // 8.75% of 100 million
            _mint(_foundationReserve, 10 * _million);  // 8.75% of 100 million
            _mint(_advisor, 5 * _million);  // 8.75% of 100 million

            require(totalSupply() == 100 * _million, "not a 100 million tokens");
        }
    }

SOLVED: The seedsale address now receives the correct amount of tokens.

The state mutability of the burn() function can be restricted to pure.

Code Location

Lord.sol

    function burn(uint256 amount) public {
        require(false, "Only burnFrom is allowed");
    }

SOLVED: The SeaScape team has removed the affected function.