New Staking Saloon - Seascape

None

Code Location

NewStakingSaloon.sol Lines# 512-540

    //Get check-in revenue
    function getSignInReward(uint256 _sessionId, uint8 _tagNum, uint8 v, bytes32 r, bytes32 s) external 
        Params storage params = signinRewards[_sessionId][_tagNum];
        Session storage _session = sessions[_sessionId];
        require(received[_sessionId][msg.sender][_tagNum] == false, "saloon: this signid reward is already received");
        require(_tagNum <= _session.signinRewardNum, "saloon: this reward do not _tagNum");
        IERC20 token = IERC20(params.token);
        uint256 NftId = 0;

        {
            bytes32 _messageNoPrefix = keccak256(abi.encodePacked(_sessionId, _tagNum, msg.sender));
            bytes32 _message = keccak256(abi.encodePacked("\x19Ethereum Signed Message:\n32", _messageNoPrefix));
            address _recover = ecrecover(_message, v, r, s);
            require(_recover == verifier,  "Verification failed");
        }

        if (params.quality > 0) {
           NftId = nftFactory.mintQuality(msg.sender, params.generation, params.quality);
        }

        if (params.amount > 0) {
            require(token.transferFrom(owner(), msg.sender, params.amount), "saloon: transferFrom reward failed");
        }
        received[_sessionId][msg.sender][_tagNum] = true;
        emit GetSignInReward(msg.sender, _sessionId, _tagNum, NftId, params.amount);
    }

RISK ACCEPTED: The Seascape team accepted the risk, as they will only use a trusted token, Crowns.

\newpage

Testing revealed that when a session is created, there are no checks to ensure that the contract balance is enough to pay the reward. This could lead to failed transactions when users unstake or claim their rewards.

Code Location

NewStakingSaloon.sol Lines# 117-156

function startSession(
    address _rewardToken,
    uint256 _totalReward,
    uint256 _period,
    uint256 _startTime,
    address _verifier
)
    external
    onlyOwner
{
    require(_rewardToken != address(0), "Token can't be zero address");
    require(_startTime > block.timestamp, "Seascape Staking: Seassion should start in the future");
    require(_period > 0, "Seascape Staking: Session duration should be greater than 0");
  require(_totalReward > 0, "Seascape Staking: Reward amount should be greater than 0");
    require(_verifier != address(0), "verifier can't be zero address");

    if (lastSessionId > 0) {
        require(!isActive(lastSessionId), "Seascape Staking: Can't start when session is active");
    }

    /// @dev required CWS balance of this contract
    // require(crowns.balanceOf(address(this)) >= _totalReward, "Seascape Staking: Not enough balance of Crowns for reward");

    //--------------------------------------------------------------------
    // creating the session
    //--------------------------------------------------------------------
    uint256 _sessionId = sessionId.current();
    uint256 _rewardUnit = _totalReward.mul(MULTIPLIER).div(_period);
    sessions[_sessionId] = Session(_totalReward, _period, _startTime, 0, 0, _rewardUnit, 0, 0, _startTime, true, false, 0);

    //--------------------------------------------------------------------
    // updating rest of session related data
    //--------------------------------------------------------------------
    sessionId.increment();
    rewardToken = IERC20(_rewardToken);
    lastSessionId = _sessionId;
    verifier = _verifier;

    emit SessionStarted(_sessionId, _totalReward, _startTime, _startTime + _period);
}

SOLVED: The Seascape team amended the code to add contract balance checks.

\newpage

There are instances within the code where commented code is left from previous development iterations. While this does not cause any security concerns, it makes the contract less readable.

Code Location

NewStakingSaloon.sol Lines# 137-138

SOLVED: The Seascape team removed commented code for readability.

\newpage

In the loop below, the variable i is incremented using i++. It is known that, in loops, using ++i costs less gas per iteration than i++. This does not only apply to the iterator variable. It also applies to variables declared within the loop code block.

Code Location

NewStakingSaloon.sol Line #372-374

   for(uint _index = 0; _index < 3; _index++){
        _interests = _interests.add(calculateInterest(_sessionId, msg.sender, _index));
    }

SOLVED: The Seascape team amended the code as suggested to optimize the contract.

\newpage